Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Telemetry plugins' Elasticsearch client #86907

Closed
wants to merge 45 commits into from
Closed

Migrate Telemetry plugins' Elasticsearch client #86907

wants to merge 45 commits into from

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Dec 23, 2020 •
edited
Loading

Summary

Migrates the telemetry-related plugins' elasticsearch client to the new client.
Removes support for the legacy elasticsearch client from the usage_collector's fetch context.
Resolves #83124

Note: The open PR's for migrating the following usage collector's elasticsearch client to the new client were merged preemptively into this PR:
rollup merged to master
uptime merged to master
security_solution merged to master
spaces merged to master

Checklist

Delete any items that are not applicable to this PR.

For maintainers

Dev docs

This PR removes support for the legacy elasticsearch client from the usage_collector's fetch context.

TinaHeiligers and others added 30 commits December 18, 2020 13:00
@TinaHeiligers
You've gotta start somewhere
fc68cb9
@TinaHeiligers
refactors collector_set unit tests
dca2be7
@TinaHeiligers
Migrates telemetry_collection_manager and telemetry plugin esClient t…
8779e10 
…o the new client
@TinaHeiligers
merges in kql_collector migration
134f1c5
@TinaHeiligers
Merge branch 'master' into telemetry_plugins_es_migration_1
062e287
@TinaHeiligers
Removes legacy import
bb79fdd
@TinaHeiligers
Merge branch 'master' into telemetry_plugins_es_migration_1
1f9c86a
@TinaHeiligers
Merge branch 'master' of github.com:elastic/kibana into telemetry_plu…
7686a39 
…gins_es_migration_1
@TinaHeiligers
Switches rollup usage collector's fetch es client to the client
f775297
@TinaHeiligers
Refactors remaining search request
0abf978
@TinaHeiligers
Merge branch 'master' into telemetry_plugins_es_migration_1
4a00518
@TinaHeiligers
Describes ts-ignore reason better
6231adb
@kibanamachine
Merge branch 'master' into uptime-usage-collector-refactor
3788b87
@TinaHeiligers
Merge branch 'master' into uptime-usage-collector-refactor
eb87c64
@TinaHeiligers
Refactors to fix types
e2014a3
@TinaHeiligers
Merge branch 'master' into telemetry_plugins_es_migration_1
9211b46
@TinaHeiligers
Refactors usage collector to use the new elasticsearch client rather …
218b2b1 
…than the deprecated legacy client
@TinaHeiligers
refactors spaces_usage_collector, test updates are WIP
c1141d5
@TinaHeiligers
Initial few tests refactored
4d43430
@TinaHeiligers
Refactors error handling and basic license tests
53289ea
@TinaHeiligers
Improves types
920cb24
@TinaHeiligers
Merge branch 'master' into spaces-usage-collector-CHANGME
f70896a
@TinaHeiligers
Refactors unit tests to use the new elasticsearch client
21a1d02
@TinaHeiligers
clean up
930bb6d
@TinaHeiligers
Remove unused types
35744d8
@TinaHeiligers
Merge branch 'rollup-usage-collector-fetch-client' into telemetry_plu…
66d2605 
…gins_migrated_test
@TinaHeiligers
Merge branch 'uptime-usage-collector-refactor' into telemetry_plugins…
a1fe032 
…_migrated_test
@TinaHeiligers
Merge branch 'security-solution-migrate-fetch-esclient' into telemetr…
58bcbdd 
…y_plugins_migrated_test
@TinaHeiligers
Merge branch 'spaces-usage-collector-migration' into telemetry_plugin…
f1e6a5f 
…s_migrated_test
@TinaHeiligers
Merge branch 'master' into telemetry_plugins_es_migration_1
d34bbfd
@TinaHeiligers TinaHeiligers added Feature:Telemetry release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.12.0 v8.0.0 labels Dec 23, 2020
@TinaHeiligers TinaHeiligers changed the title Telemetry plugins migrated test Migrate Telemetry plugins' Elasticsearch client Dec 27, 2020
@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47252 48012 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TinaHeiligers
Copy link
Contributor Author

Closing this PR since #87356 has a cleaner history.

@TinaHeiligers TinaHeiligers deleted the telemetry_plugins_migrated_test branch January 12, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature:Telemetry release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Telemetry][Usage Collection] Finish migration to the new elasticsearch client
2 participants
@TinaHeiligers @kibanamachine